Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: html-lang-valid changes (PR #1152) #1140

Closed
jeeyyy opened this issue Sep 18, 2018 · 0 comments
Closed

Rule: html-lang-valid changes (PR #1152) #1140

jeeyyy opened this issue Sep 18, 2018 · 0 comments
Assignees

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 18, 2018

The rule is ignoring xml:lang in the selector.

Test case:

The xml:lang attribute value is not a valid primary language subtag.

<html xml:lang="xyz">
@jeeyyy jeeyyy self-assigned this Sep 18, 2018
@jeeyyy jeeyyy changed the title Rule: html-lang-valid changes Rule: html-lang-valid changes (PR #1152) Sep 19, 2018
WilcoFiers pushed a commit that referenced this issue Sep 28, 2018
This PR enhances `html-lang-valid` rule to allow `xml:lang` attribute.

Closes issue:
- #1140

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
@jeeyyy jeeyyy closed this as completed Oct 10, 2018
Danidude pushed a commit to tingtun/axe-core that referenced this issue Nov 1, 2018
This PR enhances `html-lang-valid` rule to allow `xml:lang` attribute.

Closes issue:
- dequelabs#1140

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant