Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: SC4-1-2-aria-hidden-focus (PR#1166) #1150

Closed
jeeyyy opened this issue Sep 18, 2018 · 2 comments
Closed

Rule: SC4-1-2-aria-hidden-focus (PR#1166) #1150

jeeyyy opened this issue Sep 18, 2018 · 2 comments
Assignees
@jeeyyy
Labels
rules Issue or false result from an axe-core rule wai-tools

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 18, 2018

Spec: https://auto-wcag.github.io/auto-wcag/rules/SC4-1-2-aria-hidden-focus.html
@jeeyyy jeeyyy self-assigned this Sep 18, 2018
@jeeyyy jeeyyy added wai-tools rules Issue or false result from an axe-core rule labels Sep 18, 2018
@jeeyyy jeeyyy mentioned this issue Sep 27, 2018
Merged
4 tasks
@jeeyyy jeeyyy changed the title New Rule: SC4-1-2-aria-hidden-focus Rule: SC4-1-2-aria-hidden-focus (PR#1166) Sep 27, 2018
WilcoFiers pushed a commit that referenced this issue Jan 9, 2019
@jeeyyy @WilcoFiers
feat(rule): New aria-hidden-focus rule (#1166)
4489965 
Rule: Aria Hidden Focus.
Spec for rule - Spec: [auto-wcag.github.io/auto-wcag/rules/SC4-1-2-aria-hidden-focus.html](https://auto-wcag.github.io/auto-wcag/rules/SC4-1-2-aria-hidden-focus.html)

Closes issue:
- #1150

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jan 15, 2019

PR merged. Closing.

@jeeyyy jeeyyy closed this as completed Jan 15, 2019
@jkatherman
Copy link

This causes legacy modal implementations to fail where aria-hidden is used to make content outside a dialog inert, when it contains focusable items. Are screen readers sufficiently supportive of aria-modal to allow this rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
rules Issue or false result from an axe-core rule wai-tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkatherman @jeeyyy