Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messages): Change messages from "page" to "document" where appropriate #1156

Merged
merged 7 commits into from
Oct 4, 2018

Conversation

iamrafan
Copy link
Contributor

@iamrafan iamrafan commented Sep 24, 2018

A minor fix that was missed in #983

Closes issue: #983

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@iamrafan iamrafan requested a review from a team as a code owner September 24, 2018 20:52
@WilcoFiers
Copy link
Contributor

Thanks Guru. The spacing seems to be off though. Can you sort that?

@iamrafan
Copy link
Contributor Author

@WilcoFiers looks like I had the correct indentation of tabs with size 2

@WilcoFiers
Copy link
Contributor

Thinking about this a little more... I think the current description is probably better. I get where you're coming from, but according to ARIA, if you put in multiple role=document elements on the page, each of them is allowed a main role. I don't think the check currently implementation allows that, but it probably should. Thoughts?

@iamrafan
Copy link
Contributor Author

iamrafan commented Oct 2, 2018

@WilcoFiers Yes, I too feel it should allow each of the child iframes or role=document to have its own main landmark and the wording "Document" seems more appropriate than "Page".
Do you want me to change it to "Document" in all the rules/checks that we changed in #983 (comment), #1003 ?

@WilcoFiers
Copy link
Contributor

@iamrafan sounds like a plan :-)

@iamrafan
Copy link
Contributor Author

iamrafan commented Oct 4, 2018

@WilcoFiers Done, please review.

@WilcoFiers WilcoFiers changed the title fix: update page-no-duplicate-banner(check) messages fix(messages): Change messages from "page" to "document" where appropriate Oct 4, 2018
@WilcoFiers WilcoFiers merged commit 49dff2b into dequelabs:develop Oct 4, 2018
@dylanb
Copy link
Contributor

dylanb commented Oct 5, 2018

@WilcoFiers Why did this PR not run the checks before it was merged?

@WilcoFiers
Copy link
Contributor

@dylanb It did. All the checks passed. Axe is randomly failing for some reason. I saw it fail on this PR too, reran the build and it passed. There's nothing in this PR that looked like it could have caused it, so I figured the culprit was already in develop.

Danidude pushed a commit to tingtun/axe-core that referenced this pull request Nov 1, 2018
…riate (dequelabs#1156)

A minor fix that was missed in dequelabs#983 

Closes issue: dequelabs#983

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants