-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messages): Change messages from "page" to "document" where appropriate #1156
Conversation
Thanks Guru. The spacing seems to be off though. Can you sort that? |
@WilcoFiers looks like I had the correct indentation of tabs with size 2 |
Thinking about this a little more... I think the current description is probably better. I get where you're coming from, but according to ARIA, if you put in multiple |
@WilcoFiers Yes, I too feel it should allow each of the child |
@iamrafan sounds like a plan :-) |
@WilcoFiers Done, please review. |
@WilcoFiers Why did this PR not run the checks before it was merged? |
@dylanb It did. All the checks passed. Axe is randomly failing for some reason. I saw it fail on this PR too, reran the build and it passed. There's nothing in this PR that looked like it could have caused it, so I figured the culprit was already in develop. |
…riate (dequelabs#1156) A minor fix that was missed in dequelabs#983 Closes issue: dequelabs#983 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
A minor fix that was missed in #983
Closes issue: #983
Reviewer checks
Required fields, to be filled out by PR reviewer(s)