chore: update rule descriptions for landmark rules #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Oct 10, 2018
Danidude
pushed a commit
to tingtun/axe-core
that referenced
this pull request
Nov 1, 2018
4 tasks
WilcoFiers
pushed a commit
that referenced
this pull request
Nov 20, 2018
**Short Description:** Preventing us to open PR's like this - #1184 **Long Description:** There has been several PR's in the past, where changes are done, but the `rule-descriptions` are not updated, because `build` was not run as a part of the development efforts. These usually happen when the metadata of a rule spec or check spec is changed. Overhead being unrelated changes show up on other work. This PR adds `grunt configure`, which builds `doc/rule-descriptions.md` as a part of pre-commit hook. This should alleviate the above Closes issue: NA ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previously closed PR - #1156, did not run build to update the rule descriptions. This is a chore to update the rule descriptions.
Closes issue: NA
Reviewer checks
Required fields, to be filled out by PR reviewer(s)