feat(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgroup rules #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously approved these changes
Jun 18, 2019
|
Should also get @dylanb or @WilcoFiers approval before merging. |
|
Please hold this until we have had a discussion about the best path for replacement |
straker
changed the title
straker
changed the title
straker
changed the title
This was referenced Jul 29, 2019
WilcoFiers
approved these changes
Jul 30, 2019
| "metadata": { | ||
| "description": "Ensures related <input type=\"checkbox\"> elements have a group and that the group designation is consistent", | ||
| "help": "Checkbox inputs with the same name attribute value must be part of a group" | ||
| }, | ||
| "enabled": false, | ||
| "all": [], | ||
| "any": ["group-labelledby", "fieldset"], |
There was a problem hiding this comment.
I created an issue, because these two checks will also have to be deprecated. That has to be in a different PR though: #1733
|
Are there suggested replacement rules to use in place of the deprecated ones ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #176 (comment), deprecating the rules as they cause too many false positives.
As per our discussion on deprecating rules:
deprecatedtagLinked issue: #176
Closes: #1315
Reviewer checks
Required fields, to be filled out by PR reviewer(s)