Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgroup rules #1640

Merged
merged 4 commits into from
Jul 30, 2019
Merged

feat(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgroup rules #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
698e652
fix(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgrou…
straker Jun 18, 2019
07016cf
adding deprecated tag
straker Jul 26, 2019
973c0f9
rule descriptions
straker Jul 26, 2019
16cb0c7
Merge branch 'develop' into disableRaidoCheckboxRules
straker Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/rule-descriptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
| blink | Ensures <blink> elements are not used | Serious | cat.time-and-media, wcag2a, wcag222, section508, section508.22.j | true |
| button-name | Ensures buttons have discernible text | Critical | cat.name-role-value, wcag2a, wcag412, section508, section508.22.a | true |
| bypass | Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content | Serious | cat.keyboard, wcag2a, wcag241, section508, section508.22.o | true |
| checkboxgroup | Ensures related <input type="checkbox"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | true |
| checkboxgroup | Ensures related <input type="checkbox"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice, deprecated | false |
| color-contrast | Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds | Serious | cat.color, wcag2aa, wcag143 | true |
| css-orientation-lock | Ensures content is not locked to any specific display orientation, and the content is operable in all display orientations | Serious | cat.structure, wcag134, wcag21aa, experimental | true |
| definition-list | Ensures <dl> elements are structured correctly | Serious | cat.structure, wcag2a, wcag131 | true |
Expand Down Expand Up @@ -68,7 +68,7 @@
| object-alt | Ensures <object> elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true |
| p-as-heading | Ensure p elements are not used to style headings | Serious | cat.semantics, wcag2a, wcag131, experimental | true |
| page-has-heading-one | Ensure that the page, or at least one of its frames contains a level-one heading | Moderate | cat.semantics, best-practice | true |
| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | true |
| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice, deprecated | false |
| region | Ensures all page content is contained by landmarks | Moderate | cat.keyboard, best-practice | true |
| role-img-alt | Ensures [role='img'] elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true |
| scope-attr-valid | Ensures the scope attribute is used correctly on tables | Moderate, Critical | cat.tables, best-practice | true |
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/checkboxgroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"id": "checkboxgroup",
"selector": "input[type=checkbox][name]",
"tags": ["cat.forms", "best-practice"],
"tags": ["cat.forms", "best-practice", "deprecated"],
"metadata": {
"description": "Ensures related <input type=\"checkbox\"> elements have a group and that the group designation is consistent",
"help": "Checkbox inputs with the same name attribute value must be part of a group"
},
"enabled": false,
"all": [],
"any": ["group-labelledby", "fieldset"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue, because these two checks will also have to be deprecated. That has to be in a different PR though: #1733

"none": []
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/radiogroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"id": "radiogroup",
"selector": "input[type=radio][name]",
"tags": ["cat.forms", "best-practice"],
"tags": ["cat.forms", "best-practice", "deprecated"],
"metadata": {
"description": "Ensures related <input type=\"radio\"> elements have a group and that the group designation is consistent",
"help": "Radio inputs with the same name attribute value must be part of a group"
},
"enabled": false,
"all": [],
"any": ["group-labelledby", "fieldset"],
"none": []
Expand Down