Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Violations related to "Avoid inline spacing" rule of Axe-core 3.3 are not displayed. #1698

Closed
chandana7393 opened this issue Jul 11, 2019 · 11 comments
Closed

Violations related to "Avoid inline spacing" rule of Axe-core 3.3 are not displayed. #1698

chandana7393 opened this issue Jul 11, 2019 · 11 comments
Assignees
@straker
Labels
extension Axe Firefox or Chrome extension issues fix Bug fixes high High priority

Comments

@chandana7393
Copy link

chandana7393 commented Jul 11, 2019 •
edited by padmavemulapati
Loading

Steps to reproduce:

  1. Launch "Avoid inline spacing" rule related test file on the Chrome browser.
  2. Launch Axe coconut extension.
  3. Click on "Analyze" button.
    Actual:
    Issues related to Avoid inline spacing are not displayed.
    avoid_inline_spacing_violation
    Expected:
    Issues related to Avoid inline spacing must be displayed.
    Tested Environment:
    Attest-v2.5.1.20021
    Axe-coconut - 3.8.1.19204v
    Chrome - 75v
    OS - Windows 10 64 bit.

CC: @padmavemulapati
@chandana7393 chandana7393 added the high High priority label Jul 11, 2019
@chandana7393
Copy link
Author

chandana7393 commented Jul 19, 2019 •
edited
Loading

<!DOCTYPE html>
<html lang="en-US">
<head>
<title>avoid inline spacing</title>
</head>
<body>
<main>
<h1>Avoid inline spacing</h1>
<strong>Failing scenarios</strong>
<!-- style attribute includes forced line-height property -->
<p id="fail1" style="line-height: 1.5 !important;">Banana error</p>
<!-- style attribute includes forced letter-spacing property -->
<p id="fail2" style="letter-spacing: 100em !important;">We need more cheeeeeeessseeeee!!!</p>
<!-- style attribute includes forced word-spacing property -->
<p id="fail3" style="word-spacing: -.4ch !important;">
The cheese grater is in the way!</p>
<!-- style attribute a word-spacing property, a forced letter-spacing property, and a line-height -->
<p id="fail4" style="word-spacing: 200%; letter-spacing: 50rem !important; line-height: 3;">Yo, Darth Vader</p>
<strong>Passing scenarios</strong>
<!-- style attribute includes font-size property -->
<p id="pass1" style="font-size: 200%">I stepped on a Corn Flake, now I'm a Cereal Killer...</p>
<!-- style attribute includes line-height property -->
<p id="pass2" style="line-height: 1.5;">
On a scale from one to ten, what is your favorite color of the alphabet.</p>
<!-- style attribute includes letter-spacing property -->
<p id="pass3" style="letter-spacing: 50px;">
The quick brown fox jumped over the lazy dog</p>
<!-- style attribute includes word-spacing property -->
<p id="pass4" style="word-spacing: 10px;">A group of 24 Caterpillars has 694 legs</p>
<!-- style attribute includes word-spacing, letter-spacing, and line-height properties -->
<p id="pass5"
style="word-spacing: 20ch; letter-spacing: 50rem; line-height: 3;">Look, a distraction!</p>
</main>
</body>
</html>

@WilcoFiers WilcoFiers added fix Bug fixes extension Axe Firefox or Chrome extension issues high High priority and removed high High priority labels Jul 19, 2019
@WilcoFiers
Copy link
Contributor

This is quite weird. When I inject axe-core into the page directly it gives me the expected results, but then when I run axe-coconut it fails 1 thing it shouldn't, and ignores the rest (see Chandana's screenshot).

@straker
Copy link
Contributor

straker commented Aug 6, 2019 •
edited
Loading

I believe the issue is that the avoid-inline-spacing rule does not use a proper wcag tag to mark which level it is (wcag2a, wcag21aa, etc.). At least for Attest, when we select which ruleset to use, it uses the tags of the rule to determine if it's active. Without the proper wcag tag, the rule is always disabled.

https://github.com/dequelabs/axe-core/blob/develop/lib/rules/avoid-inline-spacing.json#L4

@jeeyyy jeeyyy mentioned this issue Aug 7, 2019
Merged
2 tasks
@schne324 schne324 removed their assignment Aug 7, 2019
@straker
Copy link
Contributor

straker commented Aug 7, 2019

@jeankaplansky no docs needed

@chandana7393
Copy link
Author

Tested, working fine in axe extension but in Attest and axe-coconut unable to see the violations related to avoid inline spacing.
avoid_inline_spacing_axe
avoid_inline_spacing_attest
avoid_inline_spacing_axe_coconut
Tested Environment:
Axe - 3.8.1.22021v
Attest - 2.5.1.22021v
Axe-coconut - 3.8.1.22021v
Chrome - 76.0.3809.100v
Firefox - 68.0.1v
OS - Windows 10 64 bit.

@jeankaplansky jeankaplansky mentioned this issue Aug 21, 2019
Closed
@jeankaplansky
Copy link
Contributor

See last QA note on #1301 for further information about behavior in axe-coconut and attest extensions.

@chandana7393
Copy link
Author

Tested working as expected in Attest, but in axe-coconut unable to see the violation.
axe_coconut_inline_space

Tested Environment:
Attest - 2.6.1.29416v
Axe-coconut - 4.0.0.29504v
Chrome - 77.0.3865.120v
Firefox - 69.0.3v
OS - Windows 10 64 bit.

@straker
Copy link
Contributor

straker commented Oct 22, 2019

Axe-coconut was not running any wcag21 rules, have a fix pending

@padmavemulapati
Copy link

As per the @straker , axe-coconut fix not yet available, shall we keep this ticket open?

@padmavemulapati
Copy link

we should have a fix for axe-coconut, with https://github.com/dequelabs/attest-browser-extensions/pull/1282, so will keep this ticket , not to close. Once the fix available , verify and will close.

@padmavemulapati
Copy link

seeing the fix on axe-coconut too.. (verified on the latest axe-coconut build v4.1.0.31204

--

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

Labels
extension Axe Firefox or Chrome extension issues fix Bug fixes high High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@WilcoFiers @straker @schne324 @jeankaplansky @chandana7393 @padmavemulapati