Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: Avoid inline spacing #1301

Closed
WilcoFiers opened this issue Jan 3, 2019 · 6 comments
Closed

New rule: Avoid inline spacing #1301

WilcoFiers opened this issue Jan 3, 2019 · 6 comments
Assignees
@jeankaplansky
Labels
docs Documentation changes rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

This is a rule for https://www.w3.org/TR/WCAG21/#text-spacing. Fail any element with a style attribute that sets line-height, letter-spacing or word-spacing using !important. Since this is the highest priority, custom stylesheets can't override these styles, meaning that SC1.4.12 fails.

TODO: Write up a proper proposal.
@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Jan 4, 2019
@jeeyyy
Copy link
Contributor

jeeyyy commented Feb 8, 2019 •
edited
Loading

avoid-inline-spacing

The rule should fail any element with a style attribute that sets line-height, letter-spacing or word-spacing using !important.

Tags: wcag21, wcag1412

Checks

Check that no !important style overrides are specified for line-height, letter-spacing or word-spacing properties.

Pass
If there are no !important styles applied for line-height, letter-spacing or word-spacing.

Fail
If there are !important styles applied for line-height, letter-spacing or word-spacing.

@jeeyyy jeeyyy changed the title new rule: Avoid inline spacing New rule: Avoid inline spacing Feb 19, 2019
This was referenced Mar 18, 2019
Closed
Merged
WilcoFiers pushed a commit that referenced this issue Apr 17, 2019
@jeeyyy @WilcoFiers
feat(rule): Inline text spacing must be adjustable with custom styles…
430b07f 
…heets (#1446)

Ensure text spacing is not affected by inline spacing styles that affects CSS specificity

Closes issue: 
- #1301

**Note: to make sure to make it clear in the failure message that this is due to limited support for custom stylesheets.**

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: Steve
@WilcoFiers WilcoFiers added this to the Axe-core 3.3 milestone Apr 23, 2019
@jeankaplansky jeankaplansky added the docs Documentation changes label Jun 11, 2019
@jeankaplansky jeankaplansky self-assigned this Jun 11, 2019
@jeankaplansky jeankaplansky reopened this Jun 11, 2019
@jeankaplansky
Copy link
Contributor

documented in INR - 6/17/2019

@jeankaplansky
Copy link
Contributor

https://dequeuniversity.com/rules/axe/3.3/avoid-inline-spacing

@jeankaplansky
Copy link
Contributor

DQU and Other resources added for MVP.

@chandana7393
Copy link

Tested, only in Axe extension able to see the violations related to inline spacing but in Attest and Axe-coconut unable to see the violations related to the inline spacing rule.
no_violations_inline_Attest
no_violations_inline_axe_coconut
Tested Environment:
Attest - 2.5.1.21115v
Axe - 3.8.1.21115v
Axe-coconut - 3.8.1.21304v
Chrome - 76.0.3809.87v
Firefox - 68.0.1v
OS - Windows 10 64 bit.

@jeankaplansky jeankaplansky removed their assignment Aug 21, 2019
@jeankaplansky jeankaplansky added fix Bug fixes and removed docs Documentation changes labels Aug 21, 2019
@jeankaplansky
Copy link
Contributor

Closing - See #1698.

@jeankaplansky jeankaplansky self-assigned this Aug 21, 2019
@jeankaplansky jeankaplansky added docs Documentation changes and removed fix Bug fixes labels Aug 21, 2019
@jeankaplansky jeankaplansky mentioned this issue Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeankaplansky jeankaplansky

Labels
docs Documentation changes rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@WilcoFiers @jeankaplansky @jeeyyy @chandana7393