-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse font-weight values as number in color-contrast check #2031
Labels
color contrast
Color contrast issues
fix
Bug fixes
rules
Issue or false result from an axe-core rule
Comments
Thanks for letting us know. We just released 3.5 so this probably won't get into a release for a month or two. |
straker
added
color contrast
Color contrast issues
fix
Bug fixes
rules
Issue or false result from an axe-core rule
labels
Feb 11, 2020
Thank you for your triaging.
It is OK for me. I have a workaround for this. |
takenspc
pushed a commit
to takenspc/axe-core
that referenced
this issue
Feb 12, 2020
The computed values of `font-weight` are numeric string so that we don't need to check keywords such as `bold`. The `font-weight` values are continuous. They can be `123` or `123.4` so that we should parse them as number. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide
2 tasks
WilcoFiers
pushed a commit
that referenced
this issue
Feb 12, 2020
The computed values of `font-weight` are numeric string so that we don't need to check keywords such as `bold`. The `font-weight` values are continuous. They can be `123` or `123.4` so that we should parse them as number. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide Co-authored-by: Takeshi Kurosawa <kurosawa-takeshi@mitsue.co.jp>
straker
pushed a commit
that referenced
this issue
Feb 12, 2020
The computed values of `font-weight` are numeric string so that we don't need to check keywords such as `bold`. The `font-weight` values are continuous. They can be `123` or `123.4` so that we should parse them as number. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide Co-authored-by: Takeshi Kurosawa <kurosawa-takeshi@mitsue.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
color contrast
Color contrast issues
fix
Bug fixes
rules
Issue or false result from an axe-core rule
Expectation: variable fonts offer the ability to use any weight such 750 or 850 which should be considered as bold. I expected that any weight greater than or equal to 700 are considered as bold in color-contrast check.
Actual: axe-core reports following error when
font-weight
is750
.While it doesn't report any errors if
font-weight
is700
.Motivation: we would like to change
font-weight
values as number in color-contrast checkAs far as I know, "semi" of semi-bold (600) means “partially" so that it is not considered as bold ("partially passed test" is not considered as "passed test"). If we need more discussions, I can split 2 as another issue.
The text was updated successfully, but these errors were encountered: