fix(color-contrast): properly pass options to check #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check options were not being passed to the check as it was in the wrong place in the JSON file. Moving it to the correct place caused a bug in our integration test in that a text field would return as undefined as it's visible text was empty, so we returned
undefinedinstead of passing it as the code assumed any empty text was due to unicodes.So I had to fix that by ensuring the visible text actually contained unicode characters before checking if it was empty due to removed unicode characters.
Closes issue: #1993
Reviewer checks
Required fields, to be filled out by PR reviewer(s)