Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-contrast): properly pass options to check #2033

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 10, 2020

The check options were not being passed to the check as it was in the wrong place in the JSON file. Moving it to the correct place caused a bug in our integration test in that a text field would return as undefined as it's visible text was empty, so we returned undefined instead of passing it as the code assumed any empty text was due to unicodes.

So I had to fix that by ensuring the visible text actually contained unicode characters before checking if it was empty due to removed unicode characters.

Closes issue: #1993

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner February 10, 2020 17:23
@WilcoFiers WilcoFiers merged commit 3b65eec into develop Feb 10, 2020
@straker straker deleted the fixUnicodeOptions branch February 10, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants