v4.7.1 broke node <= 6

[ljharb]

Product

axe-core

Product Version

v4.7.1

Latest Version

• I have tested the issue with the latest version of the product

Issue Description

Expectation

Be requireable in node < 6.

Actual

Crashes, because Object.values was added in node 7.

How to Reproduce

Run require('axe-core') in node 6.

Additional context

I suggest using https://npmjs.com/object.values until you're ready to release a major version that drops support for node 4-6 (please fix v4 for node <= 6 before doing that). I'd be happy to submit a PR.

[straker]

Thanks for the issue. Looks like the problem is in colorjs.io which we brought in to fix #4007.

[ljharb]

I’m confused why it would have ended up bundled into the required entrypoint node if it’s a separate package, but that explains why i couldn’t find the source code in this repo.

@LeaVerou, would you accept a PR to improve engine compat for colorjs.io?

[LeaVerou]

I’m confused why it would have ended up bundled into the required entrypoint node if it’s a separate package, but that explains why i couldn’t find the source code in this repo.

@LeaVerou, would you accept a PR to improve engine compat for colorjs.io?

Sure, though if the solution is to bundle a polyfill, I'd rather do it in a separate bundle, so that the one targeting modern environments can stay lean. We can discuss over at the colorjs repo 😊

[ljharb]

Looks like v4.8.0 also broke node < 16 by using Object.hasOwn somewhere.

[straker]

@ljharb Thanks for pointing that out. Looks like that was our fault and added in #4060

[ljharb]

@straker thanks for the pointer; filed #4152 to fix that.

[straker]

Closed via v4.8.2

[ljharb]

@straker i don't think this was fully fixed, since colorjs.io hasn't been updated to have a polyfill yet. #4127 (comment) was a separate but related issue.

[ljharb]

@straker can this please be reopened?

[straker]

Yep sorry, I closed because we fixed the Object.hasOwn problem and forgot this was talking about Object.values. We should probably bring in an Object.values polyfill to fix the color.js issue.

[ljharb]

Unfortunately if it's bundled inside color.js, i think it might need to be fixed there, but I haven't had a chance to dig into it yet.