Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should slider role be allowed for button? #4397

Closed
1 task done
msereniti opened this issue Apr 4, 2024 · 4 comments · Fixed by #4398
Closed
1 task done

Should slider role be allowed for button? #4397

msereniti opened this issue Apr 4, 2024 · 4 comments · Fixed by #4398
Labels
standards Issues in the ARIA standards objects (lib/standards)

Comments

@msereniti
Copy link
Contributor

Product

axe-core

Product Version

No response

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

As I see from html aria specification update, the slider role should be allowed for the button elements.

Actual

As I see in the axe core standards configuration file, the slider role is not in the list of roles, allowed for the button elements.

Is intended or the axe core standards file just needs an update?
@msereniti msereniti added the ungroomed Ticket needs a maintainer to prioritize and label label Apr 4, 2024
@msereniti msereniti mentioned this issue Apr 4, 2024
Merged
9 tasks
@msereniti
Copy link
Contributor Author

If needs an update I can open a pull request but just want to ensure that it's not intended.

@straker
Copy link
Contributor

straker commented Apr 4, 2024 •
edited
Loading

Thanks for the issue. It is not intentional that slider is not list, thanks for asking. A pr would be fantastic!

Just a note for for future reference, https://www.w3.org/TR/html-aria/#el-button also lists slider so the change has propagated to the published spec.

@straker straker added standards Issues in the ARIA standards objects (lib/standards) and removed ungroomed Ticket needs a maintainer to prioritize and label labels Apr 4, 2024
msereniti added a commit to msereniti/axe-core that referenced this issue Apr 4, 2024
@msereniti
fix(aria-allowed-role): added slider to allowed roles of button element
85e63c0 
dequelabs#4397
@msereniti msereniti mentioned this issue Apr 4, 2024
Merged
straker pushed a commit that referenced this issue Apr 5, 2024
@msereniti
fix(aria-allowed-role): add gridcell, separator, slider and treeitem …
4788bf8 
…to allowed roles of button element (#4398)

Closes: #4397
@msereniti
Copy link
Contributor Author

Hi @straker,
Sorry to bother you, but it would be really nice to know how axe-core release schedule works and when I can expect the introduced change to be rolled out as part of a new release?

@straker
Copy link
Contributor

straker commented Apr 10, 2024

Axe-core doesn't have any set release schedule. We just released v4.9.0 so the next minor release probably wont' happen for awhile. We release patch versions as we need them, so can't say when these changes will go out in v4.9.1.

@msereniti msereniti mentioned this issue Jul 3, 2024
Merged
9 tasks
msereniti added a commit to semrush/intergalactic that referenced this issue Jul 10, 2024
@msereniti
[86bybnf3u][slider] changed slider container tag to button and added …
bcb2d33 
…label referencing (#1491)

<!--- Provide a general summary of your changes in the Title above -->

## Motivation and Context

This task was blocked by
dequelabs/axe-core#4397
Now slider works well with `label` tags that reference to slider.

## How has this been tested?

Manually.

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected).
- [x] Nice improve.

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] My code follows the code style of this project.
- [x] I have updated the documentation accordingly or it's not required.
- [x] Unit tests are not broken.
- [x] I have added changelog note to corresponding `CHANGELOG.md` file
with planned publish date.
- [ ] I have added new unit tests on added of fixed functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
standards Issues in the ARIA standards objects (lib/standards)
Projects
None yet
Milestone
No milestone
2 participants
@straker @msereniti