Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype.js breaks axe-core v4.9.0 #4428

Closed
straker opened this issue Apr 25, 2024 · 2 comments · Fixed by #4429
Closed

prototype.js breaks axe-core v4.9.0 #4428

straker opened this issue Apr 25, 2024 · 2 comments · Fixed by #4429
Assignees

Comments

@straker
Copy link
Contributor

straker commented Apr 25, 2024

Websites that use prototype.js cause axe-core v4.9.0 to not be able to load. When trying to load axe-core on the page we get an error Uncaught TypeError: No color space found with id = "oklch".

In order to get v4.9.0 working we are going to revert our update to colorjs from v0.5.0. This will allow axe-core to load on the page but will cause color-contrast to error during it's run. To fix that we're going to load an Array.from polyfill right before we call colorjs code to fix the problem, then restore the prototype.js Array.from implementation right afterwards.

@straker straker added this to the Axe-core 4.9.1 milestone Apr 25, 2024
@straker straker self-assigned this Apr 25, 2024
straker added a commit that referenced this issue Apr 25, 2024
…ith prototype.js (#4429)

This [puts back the v0.4.3
code](#4366) in `color.js` to
handle colorjs.io not handling rad and turn values in hsl.

I also decided to use core-js `Array.from` polyfill rather than our own
internal one since I needed to bring it in outside of the `polyfill.js`
file and could then add it as an import and reuse it in both places.

Closes: #4428
@romankulkovsf

This comment was marked as off-topic.

@padmavemulapati
Copy link

Validated with the latest axe-core dev branch code base, now on websites that uses prototype.js (http://script.aculo.us/), we are able to load and getting the a11y issues if any. But not getting color space with id="oklch"

Screen.Recording.2024-05-06.at.3.52.15.PM.mov

Environment:

Label Value
Product axe-core
Version 4.9.0(Dev Branch Code base
OS-Details _MAC- Intel Core i7 - 11.6.8 _
BrowserDetails Chrome Version 124.0.6367.119 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants