Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using all-lang option for build doesn't work #4485

Closed
straker opened this issue Jun 3, 2024 · 0 comments · Fixed by #4486 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Closed

Using all-lang option for build doesn't work #4485

straker opened this issue Jun 3, 2024 · 0 comments · Fixed by #4486 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Assignees
@isner
Labels
build Issues with the build process good first issue For first-time contributors

Comments

@straker
Copy link
Contributor

straker commented Jun 3, 2024

The following does not currently work:

grunt build --all-lang
npm run build -- --all-lang

When we added the _template.json and the README.md files we forgot to test that the all-lang build option for building all locale versions of axe-core worked. We need to ignore those two files from the code path.
@straker straker added fix Bug fixes good first issue For first-time contributors build Issues with the build process and removed fix Bug fixes labels Jun 3, 2024
@isner isner self-assigned this Jun 3, 2024
@isner isner mentioned this issue Jun 3, 2024
Merged
straker pushed a commit that referenced this issue Jun 3, 2024
@isner
fix(build): limit locales to valid files when using the --all-lang op…
d3db593 
…tion (#4486)

This change updates the code path that is invoked when the build is run
using the `--all-lang` option. When assembling the list of locale files
from the `/locales` directory, this change only includes files that
satisfy _both_ of the following criteria:

- Does not start with `_`
- Ends with `.json`

This effectively excludes `_template.json` and `README.md`, and may
proactively filter out future utility files that do not follow the
typical locale-file naming standard.

Closes: #4485
@attest-team-ci attest-team-ci mentioned this issue Jul 29, 2024
Merged
WilcoFiers added a commit that referenced this issue Jul 29, 2024
@WilcoFiers
chore(release): v4.10.0 (#4545)
c49c8ea 
##
[4.10.0](v4.9.1...v4.10.0)
(2024-07-29)

### Features

- **new-rule:** summary elements must have an accessible name
([#4511](#4511))
([0d8a99e](0d8a99e)),
closes [#4510](#4510)

### Bug Fixes

- **all-rules:** fix flakey all-rules firefox test
([#4467](#4467))
([3f13aa1](3f13aa1))
- **aria-allowed-attr:** allow aria-multiline=false for element with
contenteditable
([#4537](#4537))
([f019068](f019068))
- **aria-allowed-attr:** allow aria-required=false when normally not
allowed ([#4532](#4532))
([2e242e1](2e242e1))
- **aria-prohibited-attr:** allow aria-label/ledby on decendants of
widget ([#4541](#4541))
([07c5d91](07c5d91))
- **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' }
([#4526](#4526))
([5b4cb9d](5b4cb9d)),
closes [#4523](#4523)
- **autocomplete-valid:** incomplete for invalid but safe values
([#4500](#4500))
([e31a974](e31a974)),
closes [#4492](#4492)
- **build:** limit locales to valid files when using the --all-lang
option ([#4486](#4486))
([d3db593](d3db593)),
closes [#4485](#4485)
- colorio.js patch mocking CSS
([#4456](#4456))
([3ef9353](3ef9353)),
closes [#4400](#4400)
- correct typos in texts
([#4499](#4499))
([11fad59](11fad59))
- **landmark-unique:** follow spec, aside -> landmark
([#4469](#4469))
([e32f803](e32f803)),
closes [#4460](#4460)
- **required-attr:** allow aria-valuetext on slider instead of valuenow
([#4518](#4518))
([135898b](135898b)),
closes [#4515](#4515)

This PR was opened by a robot 🤖 🎉
@Stanislav1975 Stanislav1975 mentioned this issue Aug 19, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Sep 9, 2024
Open
@organich organich mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isner isner

Labels
build Issues with the build process good first issue For first-time contributors
Projects
None yet
Milestone
No milestone
2 participants
@straker @isner