Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCAG 2.0 1.4.3 (Incidental) #596

Closed
MrGrigri opened this issue Nov 1, 2017 · 0 comments
Closed

WCAG 2.0 1.4.3 (Incidental) #596

MrGrigri opened this issue Nov 1, 2017 · 0 comments
Labels
color contrast Color contrast issues

Comments

@MrGrigri
Copy link

MrGrigri commented Nov 1, 2017

I have come across an error involving WCAG 2.0 1.4.3 (Incidental). I have an input checkbox element that is disabled. I am styling the text next to it utilizing the disabled pseudo-class and adjacent sibling CSS selectors. From what the regulation states for 'Incidental' or disabled text, these are an exemption to the rule. I have a Codepen if you would like to see it in action. I know that it meets the requirement, however, I thought that y'all could update the formula to see if the selector has 'disabled' in it.

here is a CodePen example.
@marcysutton marcysutton added the color contrast Color contrast issues label Nov 8, 2017
marcysutton pushed a commit that referenced this issue Nov 8, 2017
fix(color-contrast): allow disabled label children
0c3bb7c 
Closes #596
marcysutton pushed a commit that referenced this issue Nov 8, 2017
fix(color-contrast): allow disabled label children
c2711f2 
Closes #596
marcysutton pushed a commit that referenced this issue Nov 25, 2017
fix(color-contrast): allow disabled label children
d65df7b 
Closes #596
marcysutton pushed a commit that referenced this issue Dec 12, 2017
fix(color-contrast): allow disabled label children
6fcaf93 
Closes #596
marcysutton added a commit that referenced this issue Dec 14, 2017
@marcysutton
fix: color contrast misc (#639) Closes #607, #556
7cb0325 
* fix(color-contrast): incl. elements w/ line breaks

Closes #607
Closes #556

* fix(color-contrast): allow disabled label children

Closes #596

* fix: adjust color algorithm for inline elements

Elements spanning multiple lines now pass coordinates from their first box/rectangle to document.elementsFromPoint for gathering an element stack.

* fix: handle contrast of multiline inline el's

* test: ignore Phantom's LIES about color contrast

* test: remove failing test

TODO: address in #621

* chore: fix formatting issue
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
@stephenmathieson
Merge pull request dequelabs#596 from dequelabs/master
66d40a1 
chore: merge master into develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
color contrast Color contrast issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcysutton @MrGrigri