Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'empty-heading' rule fails if role is set on <h1>-<h6> tags #645

Closed
iamrafan opened this issue Dec 14, 2017 · 3 comments
Closed

'empty-heading' rule fails if role is set on <h1>-<h6> tags #645

iamrafan opened this issue Dec 14, 2017 · 3 comments
Labels
best practice fix Bug fixes rules Issue or false result from an axe-core rule support

Comments

@iamrafan
Copy link
Contributor

Ex:

<h1 role="banner" id="heading-1">Headings test</h1>

'empty-heading' rule failure might not be appropriate in such cases

@marcysutton
Copy link
Contributor

That does seem like the wrong outcome for this. A better message would be a best practice reminding about the second rule of ARIA: not overriding native semantics https://www.w3.org/TR/using-aria/#second

@iamrafan
Copy link
Contributor Author

Sounds good, it makes a good case for a new best practice rule.

@iamrafan
Copy link
Contributor Author

iamrafan commented Mar 7, 2018

thanks @WilcoFiers

@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
Development

No branches or pull requests

3 participants