Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty string values for 'aria-current' attribute #994

Closed
iamrafan opened this issue Jul 9, 2018 · 7 comments
Closed

Allow empty string values for 'aria-current' attribute #994

iamrafan opened this issue Jul 9, 2018 · 7 comments
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support

Comments

@iamrafan
Copy link
Contributor

iamrafan commented Jul 9, 2018

ARIA 1.1 spec for aria-current states

If the attribute is not present or its value is an empty string or undefined, the default value of false applies and the aria-current state MUST NOT be exposed by user agents or assistive technologies.

Consider allowing empty strings for aria-current

axe-core version: 3.0.3
axe-Coconut version: 3.4.0-alpha.2
@WilcoFiers WilcoFiers added the fix Bug fixes label Jul 9, 2018
@WilcoFiers
Copy link
Contributor

Sounds easy enough :)

@marcysutton
Copy link
Contributor

We should test this to make sure it is accessibility supported.

@iamrafan
Copy link
Contributor Author

AT test results for aria-current

  Browser/AT aria-current="" Announced as aria-current="false" Announced as aria-current="true" Announced as
1 Edge/Narrator Not announced Not announced Not announced
2 Edge/JAWS Not announced Not announced Not announced
3 Edge/NVDA Not announced Not announced "Label" current
4 Chrome/NVDA Not announced Not announced "Label" current
5 Chrome/JAWS Not announced Not announced "Label" current
6 IE/JAWS Not announced Not announced "Label" current
7 IE/NVDA Not announced Not announced "Label" current
8 Safari/voiceover/OS X Not announced Not announced Not announced
9 Firefox/NVDA Not announced Not announced "Label" current

@WilcoFiers
Copy link
Contributor

Looking into a fix on this, made wonder if we should just add an "allowEmpty" property to our aria attributes.

@WilcoFiers WilcoFiers mentioned this issue Jul 13, 2018
Merged
4 tasks
@iamrafan
Copy link
Contributor Author

iamrafan commented Sep 14, 2018 •
edited
Loading

@WilcoFiers looks like this issue has not been fixed, aria-current="" still fails

@WilcoFiers WilcoFiers reopened this Sep 19, 2018
@WilcoFiers
Copy link
Contributor

Apologies, closed it by accident. Thanks for the catch :-).

@iamrafan
Copy link
Contributor Author

Np, thanks for reopening the issue

@WilcoFiers WilcoFiers mentioned this issue Sep 20, 2018
Merged
4 tasks
@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Oct 18, 2018
WilcoFiers added a commit that referenced this issue Nov 14, 2018
@WilcoFiers
feat: Add allowEmpty option for aria-valid-attr-value (#1154)
89d18d0 
Allow specifying per ARIA attribute which ones are allowed to be empty. Changes include:
- aria-haspopup: Now allowed to be empty
- aria-invalid: Now allowed to be empty
- aria-current: Now allowed to be empty
- aria-valuetext: No longer allowed to be empty

Closes #994

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: Jey
@wittjeff wittjeff mentioned this issue Dec 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @marcysutton @iamrafan