Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: More div tests for only-dlitems #1088

Merged
merged 6 commits into from
Oct 24, 2018
Merged

test: More div tests for only-dlitems #1088

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20bc1e5
fix: Allow divs as groups in dl
WilcoFiers Aug 15, 2018
be13609
test: More div tests for only-dlitems
WilcoFiers Aug 22, 2018
4cf36d4
chore: Merge develop into dl-divs-more
WilcoFiers Aug 22, 2018
73b06a3
chore: Merge from develop
WilcoFiers Sep 25, 2018
541e9b2
chore: Add another only-dlitem test
WilcoFiers Sep 25, 2018
cb5bc2b
Merge branch 'develop' into dl-divs-more
jeeyyy Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions test/checks/lists/only-dlitems.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,27 @@ describe('only-dlitems', function() {
);
});

it('should return false if there is an empty div', function() {
var checkArgs = checkSetup('<dl id="target"><div></div></dl>');
assert.isFalse(
checks['only-dlitems'].evaluate.apply(checkContext, checkArgs)
);
});

it('should return true if there is a div with text', function() {
var checkArgs = checkSetup('<dl id="target"><div>text</div></dl>');
assert.isTrue(
checks['only-dlitems'].evaluate.apply(checkContext, checkArgs)
);
});

it('should return true if there is a div with non-dd / dt elements', function() {
var checkArgs = checkSetup('<dl id="target"><div> <p>text</p> </div></dl>');
assert.isTrue(
checks['only-dlitems'].evaluate.apply(checkContext, checkArgs)
);
});

(shadowSupport.v1 ? it : xit)(
'should return false in a shadow DOM pass',
function() {
Expand Down