Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new rule landmark-complementary-is-top-level #1239

Merged
merged 6 commits into from
Dec 4, 2018
Merged

feat: new rule landmark-complementary-is-top-level #1239

merged 6 commits into from
Dec 4, 2018

Commits on Nov 19, 2018

  1. feat: new rule landmark-complementary-is-top-level 

    Best practice requiring asides and complementary landmarks to be top level, in line with the ARIA Authoring Practices Guide.

Closes #795
    Marcy Sutton committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    65a8485 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. fix: remove matches from top-level aside rule 

    The first version of this rule included a body context check copied over from the top-level-banner-landmark rule, and it made very flaky iframe tests. It wasn't really necessary since aside doesn't have the same behavior as header/role=banner.
    Marcy Sutton committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    eb71ca6 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Merge remote-tracking branch 'origin/develop' into landmark-complemen… 

    …tary-top-level
    Marcy Sutton committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    2bf6cfd View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Merge remote-tracking branch 'origin/develop' into landmark-complemen… 

    …tary-top-level
    Marcy Sutton committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    06bad40 View commit details
    Browse the repository at this point in the history

  2. test: improve readability of landmark check

    Marcy Sutton committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    08a6fba View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Merge remote-tracking branch 'origin/develop' into landmark-complemen… 

    …tary-top-level
    Marcy Sutton committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    66e434a View commit details
    Browse the repository at this point in the history