Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set preload:true as default #1281

Merged
merged 4 commits into from
Dec 18, 2018
Merged

fix: set preload:true as default #1281

merged 4 commits into from
Dec 18, 2018

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Dec 17, 2018 •
edited by WilcoFiers
Loading

This PR does the below:

  • Set's preload: true by default.
  • Updates preload related tests.
  • Updates preload API documentation.
  • This allows for experimental rules like css-orientation-lock, to be run with out passing an extra flag from products like extensions.

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested a review from a team as a code owner December 17, 2018 18:31
@WilcoFiers WilcoFiers merged commit c9731c8 into develop Dec 18, 2018
@WilcoFiers WilcoFiers deleted the run-preload-by-default branch December 18, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@marcysutton marcysutton Awaiting requested review from marcysutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeeyyy @WilcoFiers