-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run-virtual-rule): new api to run rules using only virtual nodes #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
feat(run-virtual-rule): new api to run rules using only virtual nodes
[WIP] feat(run-virtual-rule): new api to run rules using only virtual nodes
May 28, 2019
straker
changed the title
[WIP] feat(run-virtual-rule): new api to run rules using only virtual nodes
feat(run-virtual-rule): new api to run rules using only virtual nodes
May 28, 2019
stephenmathieson
previously requested changes
May 29, 2019
straker
changed the title
feat(run-virtual-rule): new api to run rules using only virtual nodes
[WIP] feat(run-virtual-rule): new api to run rules using only virtual nodes
May 29, 2019
straker
changed the title
[WIP] feat(run-virtual-rule): new api to run rules using only virtual nodes
feat(run-virtual-rule): new api to run rules using only virtual nodes
Jun 7, 2019
WilcoFiers
previously requested changes
Jun 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor point
WilcoFiers
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This api allows a user to run a rule without needing an actual DOM node. It completes the api needed to run a rule in a linter on individual virtual nodes.
Linked issue: #1601
Reviewer checks
Required fields, to be filled out by PR reviewer(s)