Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(virtual-node): fix hasClass to work with svg elements #1603

Merged
merged 1 commit into from
May 30, 2019
Merged

fix(virtual-node): fix hasClass to work with svg elements #1603

merged 1 commit into from
May 30, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented May 30, 2019 •
edited by stephenmathieson
Loading

SVG elements return a SVGAnimatedString object and not a string when accessing node.className.

Linked issue: #1423

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Stephen

stephenmathieson
stephenmathieson approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@straker straker merged commit 9d83662 into develop May 30, 2019
@straker straker deleted the fixSVGClassname branch May 30, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @stephenmathieson