fix(image-redundant-alt): prevent redundant issues of image tree #1616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
image-redundant-alt
rule applied to more than just buttons and links (as the help text stated). It also was being applied top
,li
,td
, andth
elements. This caused a single image to be reported multiple times if it's parent tree consisted of each of those elements:This changes the rule to focus only on
img
elements and look up the tree for thebutton
,[role=button]
,a[href]
,p
,li
,td
, andth
elements and check the text against the image alt. This way only the image node will throw the error and not each parent node.Linked issue: #1416
Reviewer checks
Required fields, to be filled out by PR reviewer(s)