-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename aria-input-field-label and aria-toggle-field-label #1656
Conversation
Is renaming a rule considered a breaking change? If custom configs were to disable it it would no longer work |
@straker these rules have not made it to a release yet. They were merged only 20 days ago.
So I do not think they would be considered a breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. We can't do this without 1. a long period of backward compatibility and 2. a major release. Neither of which is happening any time soon.
@JKODU Unfortunately they are part of the 3.3 release so we can't rename them now :( |
Confirmed that this change can be done for 3.3
@straker given @WilcoFiers has agreed for this change to be in 3.3, I will leave it with you to do the necessary cherry picking into 3.3 release. |
Renamed below rules & associated references:
aria-toggle-field-label
>aria-toggle-field-name
aria-input-field-label
>aria-input-field-name
Closes issue:
@straker - if and when this is merged this needs to become a part of 3.3 release.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)