Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename aria-input-field-label and aria-toggle-field-label #1656

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Jun 25, 2019

Renamed below rules & associated references:

  • aria-toggle-field-label > aria-toggle-field-name
  • aria-input-field-label > aria-input-field-name

Closes issue:

@straker - if and when this is merged this needs to become a part of 3.3 release.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Steve

@jeeyyy jeeyyy requested a review from a team as a code owner June 25, 2019 14:34
@straker
Copy link
Contributor

straker commented Jun 25, 2019

Is renaming a rule considered a breaking change? If custom configs were to disable it it would no longer work

@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jun 26, 2019

@straker these rules have not made it to a release yet. They were merged only 20 days ago.

So I do not think they would be considered a breaking change.

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. We can't do this without 1. a long period of backward compatibility and 2. a major release. Neither of which is happening any time soon.

@straker
Copy link
Contributor

straker commented Jun 26, 2019

@JKODU Unfortunately they are part of the 3.3 release so we can't rename them now :(

@jeeyyy jeeyyy dismissed WilcoFiers’s stale review July 2, 2019 14:56

Confirmed that this change can be done for 3.3

@jeeyyy jeeyyy requested review from WilcoFiers and straker July 2, 2019 14:56
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jul 2, 2019

@straker given @WilcoFiers has agreed for this change to be in 3.3, I will leave it with you to do the necessary cherry picking into 3.3 release.

@straker straker changed the title fix(rule): rename rule(s) to aria-input-field-name and aria-toggle-field-name refactor: rename aria-input-field-name and aria-toggle-field-name Jul 2, 2019
@straker straker changed the title refactor: rename aria-input-field-name and aria-toggle-field-name refactor: rename aria-input-field-label and aria-toggle-field-label Jul 2, 2019
@straker straker merged commit 1f602c9 into develop Jul 2, 2019
@straker straker deleted the rule-rename-aria-form-field branch July 2, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants