Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure locale files are valid #1673

Merged
merged 4 commits into from
Jul 9, 2019
Merged

test: ensure locale files are valid #1673

merged 4 commits into from
Jul 9, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 3, 2019 •
edited by stephenmathieson
Loading

Closes: #1660

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Stephen

@straker straker requested a review from a team as a code owner July 3, 2019 21:55
stephenmathieson
stephenmathieson previously requested changes Jul 3, 2019
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Few small things, but this is great!

test/test-locales.js Outdated Show resolved Hide resolved
test/test-locales.js Outdated Show resolved Hide resolved
@straker straker merged commit 588f9b5 into develop Jul 9, 2019
@straker straker deleted the testLocales branch July 9, 2019 15:58
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
@straker @WilcoFiers
test: ensure locale files are valid (#1673)
653137f 
* test: test that locale files are valid

* relative paths from file

* build before testing

* make sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a test ensuring locale data is valid
2 participants
@straker @stephenmathieson