Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(video-description): deprecate video-description rule #1737

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 30, 2019

Per Wilco's suggestion in the linked issue, only 1 minor media player supports <track kind="description"...>.

Closes issue: #1712

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

@straker straker requested a review from a team as a code owner July 30, 2019 21:14
@straker straker changed the title Deprecated video description feat(video-description): deprecated video-description rule Jul 31, 2019
@jeeyyy
Copy link
Contributor

jeeyyy commented Aug 1, 2019

This looks good, but according to this doc - https://github.com/dequelabs/axe-core/blob/develop/doc/backwards-compatibility-doc.md#table-summary-of-what-deque-guarantees-with-public-axe-core-api, need to keep some track of all the deprecated stuff so we know we do the right version bump when time comes to it.

@straker straker changed the title feat(video-description): deprecated video-description rule feat(video-description): deprecate video-description rule Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants