feat(non-space-content): switch all non-empty checks to new generic check #2215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-empty-alt
,non-empty-title
, andnon-empty-value
were all the same function so combined them into a single generic check. Generic checks are new checks that don't have metadata files associated with them so are just evaluate functions called from other checks (can't be used directly in a rule). They typically will need options passed into them to work.I talked to wilco about
non-empty-title
usingtitleText
function and he said it didn't need to do that so was fine to just look at the title attribute directly.Lastly, all the tests for the old checks are the exact same, especially since now they use the same evaluate underneath. I think we should remove them and just have a single test for the generic one and let the integration tests for the rules that use these checks catch things, but we should discuss that here.
Closes issue: #2192
Reviewer checks
Required fields, to be filled out by PR reviewer(s)