Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(duplicate-img-label): add option for parentSelector #2216

Merged
merged 4 commits into from
May 14, 2020
Merged

feat(duplicate-img-label): add option for parentSelector #2216

merged 4 commits into from
May 14, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented May 6, 2020 •
edited by WilcoFiers
Loading

Part of #2195. findUpVirtual is deprecated so switched it to axe.utils.closest.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner May 6, 2020 22:53
WilcoFiers
WilcoFiers previously requested changes May 7, 2020
View reviewed changes
lib/checks/label/duplicate-img-label-evaluate.js Outdated Show resolved Hide resolved
@straker straker mentioned this pull request May 7, 2020
Merged
2 tasks
@straker straker merged commit 8906806 into develop May 14, 2020
@straker straker deleted the duplicate-img-label branch May 14, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers