fix(forms/*): allow all form control value checks to work with virtual nodes #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Jul 2, 2020
WilcoFiers
approved these changes
Jul 7, 2020
| (nodeName === 'INPUT' && !nonTextInputTypes.includes(node.type)) | ||
| nodeName === 'textarea' || | ||
| (nodeName === 'input' && | ||
| !nonTextInputTypes.includes((node.attr('type') || '').toLowerCase())) |
There was a problem hiding this comment.
May not be necessary for this PR, but I think we should consider adding virtualNode.props.type by default, in the same way that we set nodeType. That way we don't have to do this type casting, and it'd give us an easier way to deal with inputs defaulting to type=text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue: #2183 of checks that use accessible-text-virtual code path (for example,
focusable-no-name)Reviewer checks
Required fields, to be filled out by PR reviewer(s)