Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(label): work with virtual nodes #2354

Merged
merged 8 commits into from
Jul 20, 2020
Merged

fix(label): work with virtual nodes #2354

merged 8 commits into from
Jul 20, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 8, 2020 •
edited by WilcoFiers
Loading

This one was a lot of changes to be able to get the rule to work with serial virtual nodes.

Part of #2183

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 8, 2020 21:10
WilcoFiers
WilcoFiers previously requested changes Jul 9, 2020
View reviewed changes
lib/checks/label/implicit-evaluate.js Show resolved Hide resolved
lib/commons/text/label-virtual.js Outdated Show resolved Hide resolved
lib/commons/text/label-virtual.js Outdated Show resolved Hide resolved
@straker
Copy link
Contributor Author

straker commented Jul 18, 2020 •
edited
Loading

Turns out help-same-as-label has been disabled for at least 2 years so no need to convert it over. Not sure why we still have it as part of the check at this point.

@straker straker mentioned this pull request Jul 18, 2020
Merged
2 tasks
WilcoFiers
WilcoFiers previously approved these changes Jul 20, 2020
View reviewed changes
WilcoFiers
WilcoFiers previously approved these changes Jul 20, 2020
View reviewed changes
@straker straker merged commit 44b033c into develop Jul 20, 2020
@straker straker deleted the label-serial branch July 20, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers