-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria-allowed-role): allow title, aria-label and aria-labelledby on a img element with a supported role #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Oct 21, 2021
test/integration/rules/aria-allowed-role/aria-allowed-role.html
Outdated
Show resolved
Hide resolved
Zidious
changed the title
fix(aria-allowed-role): allow title, aria-label and aria-labelledby on img with supported role
fix(aria-allowed-role): allow title, aria-label and aria-labelledby on a img element with a supported role
Oct 28, 2021
WilcoFiers
previously requested changes
Oct 29, 2021
WilcoFiers
previously requested changes
Nov 4, 2021
…fix-img/aria-allowed-role
WilcoFiers
previously requested changes
Nov 10, 2021
WilcoFiers
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an
img
element has atitle
,aria-label
oraria-labelledby
and a supported role i.e. button we report it as a violation, this appears to be a false positive as we do not report it as a violation when analt
tag is added.we have added a new matcher to match an element that has a non-empty accessible name. By doing so gives us the ability to add a matches property on a new variant
noAlt
that will check if theimg
element text is accessible (in this case, title, aria-label and, aria-labelledby) if analt
tag is not present.W3C resources provided by the by the author in #3143:
https://www.w3.org/TR/html-aria/#el-img-no-alt
https://www.w3.org/TR/html-aam-1.0/#img-element-accessible-name-computation
https://www.w3.org/TR/html-aria/#el-img
Closes issue: #3143