Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): make axe.ping configurable with pingWaitTime #3273

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

WilcoFiers
Copy link
Contributor

  • Document the existence of pingWaitTime
  • Have pingWaitTime: 0 skip the ping step altogether

Closes issue: #3272

@WilcoFiers WilcoFiers requested a review from a team as a code owner November 11, 2021 13:14
@WilcoFiers WilcoFiers merged commit ce4dfaf into develop Nov 12, 2021
@WilcoFiers WilcoFiers deleted the disable-axe-ping branch November 12, 2021 16:52
@scurker
Copy link
Member

scurker commented Nov 12, 2021

Just so I follow:

Setting pingWaitTime to 0 means that only an axe.run is sent? Is this making the assumption that we're re-implementing a ping in the axe extension to first validate that we can communicate with a frame?

My concern lies that if only a single call is made, we don't want to wait 60000ms to timeout if the frame is unable to communicate. We can implement our own ping method in the extension that encompasses both, but just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants