chore: generate metadata-function-map #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Feb 18, 2022
| import svgNamespaceMatches from '../../rules/svg-namespace-matches'; | ||
| import windowIsTopMatches from '../../rules/window-is-top-matches'; | ||
| import xmlLangMismatchMatches from '../../rules/xml-lang-mismatch-matches'; | ||
| // This file is automatically generated using build/tasks/metadata-function-map.js |
There was a problem hiding this comment.
If we're generating this file, why do we need it in the git repo?
WilcoFiers
approved these changes
Feb 18, 2022
straker
added a commit
that referenced
this pull request
May 12, 2022
* chore: generate metadata-function-map * cleanup * fix windows * ignore file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generate the
metadata-function-mapfile on build. This should remove the tedious nature of manually updating the file with changes.Closes issue: #2694
Closes issue: #2208