Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecated Internet Explorer support #3644

Merged
merged 3 commits into from
Sep 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,7 @@ unix_nightly_box: &unix_nightly_box
docker:
- image: cimg/node:lts-browsers

win_box: &win_box
executor:
name: win/default
shell: bash.exe

orbs:
win: circleci/windows@2.2.0
puppeteer: threetreeslight/puppeteer@0.1.2
browser-tools: circleci/browser-tools@1.1.0

Expand All @@ -30,12 +24,6 @@ restore_dependency_cache_unix: &restore_dependency_cache_unix
- v9-cache-unix-{{ checksum "package-lock.json" }}
- v9-cache-unix-

restore_dependency_cache_win: &restore_dependency_cache_win
restore_cache:
keys:
- v9-cache-win-{{ checksum "package-lock.json" }}
- v9-cache-win-

jobs:
# Fetch and cache dependencies.
dependencies_unix:
Expand All @@ -52,18 +40,6 @@ jobs:
key: v9-cache-unix-{{ checksum "package-lock.json" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also the orbs: win, restore_dependency_cache_win, and win_box steps that can be removed

paths:
- node_modules
dependencies_win:
<<: *defaults
<<: *win_box
steps:
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_win
- run: npm ci
- save_cache:
key: v9-cache-win-{{ checksum "package-lock.json" }}
paths:
- node_modules

# Run ESLINT
lint:
Expand All @@ -88,23 +64,6 @@ jobs:
- run: npm run test:integration:chrome
- run: npm run test:integration:firefox

# Run the test suite in IE in windows
test_win:
<<: *defaults
<<: *win_box
steps:
- checkout
# npm i or restore cache
- <<: *restore_dependency_cache_win
- run: npm run build
- run: npm run test -- --browsers IE
# install selenium
- run: |
choco install selenium-ie-driver --version 3.141.5
export PATH=/c/tools/selenium:$PATH
echo $PATH
- run: npm run test:integration:ie

# Run examples under `doc/examples`
test_examples:
<<: *defaults
Expand Down Expand Up @@ -312,7 +271,6 @@ workflows:
jobs:
# install deps
- dependencies_unix
- dependencies_win
# Run linting
- lint:
requires:
Expand All @@ -321,10 +279,6 @@ workflows:
- test_unix:
requires:
- lint
# Run IE/ Windows test on all commits
- test_win:
requires:
- dependencies_win
- test_examples:
requires:
- test_unix
Expand Down Expand Up @@ -354,7 +308,6 @@ workflows:
type: approval
requires:
- test_unix
- test_win
- test_examples
- test_locales
- test_virtual_rules
Expand Down
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ The [axe-core API](doc/API.md) fully supports the following browsers:
- Google Chrome v42 and above
- Mozilla Firefox v38 and above
- Apple Safari v7 and above
- Internet Explorer v11
- Internet Explorer v11 (DEPRECATED)

Support means that we will fix bugs and attempt to test each browser regularly. Only Firefox, Chrome, and Internet Explorer 11 are currently tested on every pull request.
Support means that we will fix bugs and attempt to test each browser regularly. Only Chrome and Firefox are currently tested on every pull request.

There is limited support for JSDOM. We will attempt to make all rules compatible with JSDOM but where this is not possible, we recommend turning those rules off. Currently the `color-contrast` rule is known not to work with JSDOM.

Expand Down Expand Up @@ -127,8 +127,7 @@ axe.configure({
},
'aria-errormessage': {
// Note: doT (https://github.com/olado/dot) templates are supported here.
fail:
'Der Wert der aria-errormessage ${data.values}` muss eine Technik verwenden, um die Message anzukündigen (z. B., aria-live, aria-describedby, role=alert, etc.).'
fail: 'Der Wert der aria-errormessage ${data.values}` muss eine Technik verwenden, um die Message anzukündigen (z. B., aria-live, aria-describedby, role=alert, etc.).'
}
// ...
}
Expand Down
2 changes: 1 addition & 1 deletion doc/accessibility-supported.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ We currently test the following AT combinations for support

1. VoiceOver and Safari on OS X
1. VoiceOver and Safari on iOS
1. JAWS and IE11 on Windows
1. JAWS and IE11 on Windows (DEPRECATED)
1. JAWS and Chrome on Windows
1. NVDA and Firefox on Windows
1. Talkback and Chrome on Android
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,9 @@
"integration:apg": "mocha test/aria-practices/*.spec.js",
"integration:chrome": "npm run integration -- browser=Chrome",
"integration:firefox": "npm run integration -- browser=Firefox",
"integration:ie": "npm run integration -- browser=\"Internet Explorer\"",
"test:integration": "npm run test:integration:chrome",
"test:integration:chrome": "start-server-and-test 9876 integration:chrome",
"test:integration:firefox": "start-server-and-test 9876 integration:firefox",
"test:integration:ie": "start-server-and-test 9876 integration:ie",
"test:examples": "node ./doc/examples/test-examples",
"test:act": "karma start test/act-mapping/karma.config.js",
"test:act:debug": "npm run test:act -- --no-single-run --browsers=Chrome",
Expand Down
Loading