Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils.matches): fix attribute exists selector to match empty attributes #3669

Merged
merged 4 commits into from
Sep 26, 2022
Merged

fix(utils.matches): fix attribute exists selector to match empty attributes #3669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d521ba
fix(utils.matches): fix attribute exists selector to match empty attr…
straker Sep 22, 2022
ac82a18
comments
straker Sep 22, 2022
b5f6162
Update test/core/utils/matches.js
straker Sep 23, 2022
cb9df98
Update test/core/utils/matches.js
straker Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/core/utils/matches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function matchesAttributes(vNode, exp) {
!exp.attributes ||
exp.attributes.every(att => {
var nodeAtt = vNode.attr(att.key);
return nodeAtt !== null && (!att.value || att.test(nodeAtt));
return nodeAtt !== null && att.test(nodeAtt);
})
);
}
Expand Down Expand Up @@ -108,9 +108,10 @@ function convertAttributes(atts) {
return attributeValue !== value;
};
break;
// attribute existence
default:
test = value => {
return !!value;
return value !== null;
};
}

Expand Down
Loading