fix(color-contrast-enhanced): avoid duplicates between color-contrast and color-contrast-enhanced #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at pass color-contrast
WilcoFiers
requested changes
Oct 12, 2022
WilcoFiers
previously requested changes
Oct 13, 2022
There was a problem hiding this comment.
I think I figured out the ACT issue. Probably the same as this one: #3719 Since we're avoiding overlap with the AAA rule in axe-core, to get the ACT rule tested, we need to map both axe-core rules to the ACT rule for AAA. You'll want to add 09o5cg to the actIds prop on rules/color-contrast.json, and add color-contrast to axeRules in text-contrast-enhanced-09o5cg.spec.js.
WilcoFiers
reviewed
Oct 13, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #3612