fix offScreen test failing in Chrome #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WilcoFiers
commented
Jun 20, 2017
WilcoFiers
commented
- Errors got swallowed by the browser testrunner. That’s fixed now
- Chrome was failing one of the tests due to not cleaning up scroll position
dylanb
reviewed
Jun 21, 2017
build/tasks/test-webdriver.js
Outdated
| @@ -71,6 +71,7 @@ module.exports = function (grunt) { | |||
| if (urls.length > 0) { | |||
| return runTestUrls(driver, urls, errors); | |||
| } else { | |||
| driver.quit(); | |||
| return Promise.resolve(errors); | |||
There was a problem hiding this comment.
shouldn't you call resolve inside a then after the quit?
return driver.quit().then(function () {
Promise.resolve(errors);
});
|
I think these test timeouts could use your expertise @dylanb. Also let's be sure to squash this PR when it gets merged since it has a commit that doesn't adhere to our policy. |
dylanb
force-pushed
the
fix/chrome-offscreen
branch
from
27d8f6e
to
303167c
Compare
dylanb
force-pushed
the
fix/chrome-offscreen
branch
from
303167c
to
0b0240f
Compare
|
ok, I fixed the tests - took two changes The approach I took to syncing the iframe loading could be generalized to all iframe tests by creating a utility function that we include in all iframes that allows us to tell when the iframe has loaded. |
|
Awesome!! Thanks Dylan. That's why you're the iframe king :P |
mrtnvh
pushed a commit
to mrtnvh/axe-core
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.