ci: create semantic pr title GHA #3783
Conversation
| ] | ||
| console.log('Validating PR title: "%s"', TITLE) | ||
| for (const type of types) { | ||
| if (TITLE.startsWith(type)) { |
There was a problem hiding this comment.
I'd like to see this improved so it doesn't generate false positives and negatives. Each of the following titles would pass this check even though they don't follow conventional commit specification:
fixture testsfix the testscircle ci failuresfixfix(build) update build failuresfix(build):update build failures
This also does not allow for case insensitivity, so FIX should be allowed as a type
There was a problem hiding this comment.
Let's not make this more complicated than it needs to be. This action is copypasta from dozens of other repos. We've never had an issue with it.
There was a problem hiding this comment.
@WilcoFiers a 👎 without explanation is meaningless.
There was a problem hiding this comment.
I'm with Steve on this. I'd rather have no action than one that gives me undeserved confidence. We shouldn't be copy/pasting code across repos like this either. We easily can, and should do better.
Is there any reason for us not to use this?
https://github.com/marketplace/actions/semantic-pull-request
There was a problem hiding this comment.
I'd rather have no action than one that gives me undeserved confidence.
This would flag PRs that are clearly wrong. It'd also give contributors the heads up that something needs to change. The rest should be left up to the human brain IMO.
We shouldn't be copy/pasting code across repos like this either.
A little copying is better than a little dependency. Also there's nothing stopping us from making this a public action.
Is there any reason for us not to use this?
Nope, I'd be fine with that. This was setup before that existed and has worked well for us (and other teams) for the past several months.
You and Steve seem to do a lot of gatekeeping in this repository. Michael is simply trying to help out by taking care of some low-hanging fruit. This seems like a pointless way of using your time.
<< Describe the changes >>
Closes issue: