feat: support the dialog element #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Jan 31, 2023
WilcoFiers
previously requested changes
Feb 20, 2023
| // dialog are treated as inert by the | ||
| // browser | ||
| const modalDialog = getModalDialog(); | ||
| if (modalDialog && !contains(modalDialog, vNode)) { |
There was a problem hiding this comment.
This does tell me that if we have nested open modals, we should grab the outer-most one. The way you implemented that should work though, since querySelectorAll is in that order already.
WilcoFiers
approved these changes
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3463