Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use virtualNode in title-only check #403

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Conversation

marcysutton
Copy link
Contributor

Closes #388

@marcysutton marcysutton requested a review from dylanb June 30, 2017 19:38
@marcysutton
Copy link
Contributor Author

Passing tests for title-only:

title-only
    ✓ should return true if an element only has a title
    ✓ should return true if an element only has aria-describedby

@dylanb dylanb merged commit 1677b01 into shadowDOM Jun 30, 2017
@dylanb dylanb deleted the title-check-SD branch June 30, 2017 21:05
@WilcoFiers
Copy link
Contributor

@marcysutton @dylanb Shouldn't we add shadow DOM tests for these rules?

@dylanb
Copy link
Contributor

dylanb commented Jul 1, 2017

@WilcoFiers I thought about that and I came to the conclusion that we do not need tests for every rule - however I may be wrong... here is my thinking...

If the utility functions work properly (i.e. they are tested properly) and if the rule has a good level of tests for all of its edge cases, then adding shadow DOM tests does not add more quality unless the rule has some specific functionality itself that pertains to shadow DOM.

This does not mean that we cannot add shadow DOM tests, it just means we don't necessarily need them - thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants