fix(jsdom): allow axe.setup() without a global window #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Aug 1, 2023
| @@ -36,10 +36,10 @@ export default function run(...args) { | |||
| axe.utils.performanceTimer.start(); | |||
| } | |||
|
|
|||
| function handleRunRules(rawResults, cleanup) { | |||
| function handleRunRules(rawResults, teardown) { | |||
There was a problem hiding this comment.
Since this is actually just the teardown method, it's confusing to have it named something else here.
WilcoFiers
commented
Aug 1, 2023
| @@ -66,7 +66,6 @@ export default function run(...args) { | |||
| axe.utils.performanceTimer.end(); | |||
| } | |||
| axe._running = false; | |||
| resetGlobals(); | |||
There was a problem hiding this comment.
This is already called in teardown, which is invoked earlier. Calling resetGlobals here does nothing, and wouldn't actually have worked because axe's cache has been cleaned up by this point. Same is true for the other resetGlobals() call in this file.
straker
approved these changes
Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axe.setup()should set up temporary globals whenglobalThis.windowand/orglobalThis.documentaren't set up. This PR fixes that.Closes #3962