fix(target-size): show closest offset in message #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
approved these changes
Sep 7, 2023
Yes, I will prepare a pull request and send it once this one gets finalized and merged. BTW, while it's quite easy to notice newly added messages, catching updates to existing messages is not so. I hope we can come up with some mechanism to make it easy to track the translation status, or maybe it's just that I'm not aware of some common techniques for this kind of tasks? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the remediation message. I checked the localisations, none of them have the
{$instead of${problem, although we do need the translators to fix the bracket issue I think. Hoping @ma10 can pick that up for Japanese.Closes: #4148, closes #4149