shadowDOM for media checks #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanb
requested changes
Jul 14, 2017
lib/checks/media/description.js
Outdated
| return true; | ||
| // return false if any track has kind === 'description' | ||
| var out = !tracks.some(({ actualNode }) => ( | ||
| actualNode.getAttribute('kind').toLowerCase() === 'descriptions' |
There was a problem hiding this comment.
Could you add tests for both checks that ensures that th check returns without an exception when the markup looks like
<audio><track></track></audio>
i.e. no kind attribute at all
There was a problem hiding this comment.
Right you are. .toLowerCase() wouldn't work. Will add/fix
dylanb
approved these changes
Jul 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #423.