fix(autocomplete-valid): incomplete for invalid but safe values

doc/rule-descriptions.md

@@ -77,10 +77,10 @@
 
 ## WCAG 2.1 Level A & AA Rules
 
-| Rule ID                                                                                                            | Description                                                                                   | Impact  | Tags                                                            | Issue Type | ACT Rules                                                                                                                                                  |
-| :----------------------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------- | :------ | :-------------------------------------------------------------- | :--------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| [autocomplete-valid](https://dequeuniversity.com/rules/axe/4.9/autocomplete-valid?application=RuleDescription)     | Ensure the autocomplete attribute is correct and suitable for the form field                  | Serious | cat.forms, wcag21aa, wcag135, EN-301-549, EN-9.1.3.5, ACT       | failure    | [73f2c2](https://act-rules.github.io/rules/73f2c2)                                                                                                         |
-| [avoid-inline-spacing](https://dequeuniversity.com/rules/axe/4.9/avoid-inline-spacing?application=RuleDescription) | Ensure that text spacing set through style attributes can be adjusted with custom stylesheets | Serious | cat.structure, wcag21aa, wcag1412, EN-301-549, EN-9.1.4.12, ACT | failure    | [24afc2](https://act-rules.github.io/rules/24afc2), [9e45ec](https://act-rules.github.io/rules/9e45ec), [78fd32](https://act-rules.github.io/rules/78fd32) |
+| Rule ID                                                                                                            | Description                                                                                   | Impact  | Tags                                                            | Issue Type                 | ACT Rules                                                                                                                                                  |
+| :----------------------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------- | :------ | :-------------------------------------------------------------- | :------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| [autocomplete-valid](https://dequeuniversity.com/rules/axe/4.9/autocomplete-valid?application=RuleDescription)     | Ensure the autocomplete attribute is correct and suitable for the form field                  | Serious | cat.forms, wcag21aa, wcag135, EN-301-549, EN-9.1.3.5, ACT       | failure, needs review | [73f2c2](https://act-rules.github.io/rules/73f2c2)                                                                                                         |
+| [avoid-inline-spacing](https://dequeuniversity.com/rules/axe/4.9/avoid-inline-spacing?application=RuleDescription) | Ensure that text spacing set through style attributes can be adjusted with custom stylesheets | Serious | cat.structure, wcag21aa, wcag1412, EN-301-549, EN-9.1.4.12, ACT | failure                    | [24afc2](https://act-rules.github.io/rules/24afc2), [9e45ec](https://act-rules.github.io/rules/9e45ec), [78fd32](https://act-rules.github.io/rules/78fd32) |
 
 ## WCAG 2.2 Level A & AA Rules
 

lib/checks/forms/autocomplete-valid-evaluate.js

@@ -1,6 +1,6 @@
 import { isValidAutocomplete } from '../../commons/text';
 
-function autocompleteValidEvaluate(node, options, virtualNode) {
+function autocompleteValidEvaluate(_node, options, virtualNode) {
   const autocomplete = virtualNode.attr('autocomplete') || '';
   return isValidAutocomplete(autocomplete, options);
 }

lib/checks/forms/autocomplete-valid.json

@@ -5,7 +5,8 @@
     "impact": "serious",
     "messages": {
       "pass": "the autocomplete attribute is correctly formatted",
-      "fail": "the autocomplete attribute is incorrectly formatted"
+      "fail": "the autocomplete attribute is incorrectly formatted",
+      "incomplete": "check that this invalid autocomplete attribute does not necessary for accessibility"
     }
   },
   "options": {

lib/commons/text/is-valid-autocomplete.js

@@ -59,7 +59,8 @@ export const autocomplete = {
     'email',
     'impp'
   ],
-  locations: ['billing', 'shipping']
+  locations: ['billing', 'shipping'],
+  ignoredValues: ['text', 'pronouns', 'gender', 'message', 'content']
 };
 
 function isValidAutocomplete(
@@ -117,6 +118,11 @@ function isValidAutocomplete(
   }
 
   const purposeTerm = autocompleteTerms[autocompleteTerms.length - 1];
+
+  if (autocomplete.ignoredValues.includes(purposeTerm)) {
+    return undefined;
+  }
+
   return (
     standaloneTerms.includes(purposeTerm) ||
     qualifiedTerms.includes(purposeTerm)

locales/_template.json

@@ -683,7 +683,8 @@
     },
     "autocomplete-valid": {
       "pass": "the autocomplete attribute is correctly formatted",
-      "fail": "the autocomplete attribute is incorrectly formatted"
+      "fail": "the autocomplete attribute is incorrectly formatted",
+      "incomplete": "check that this invalid autocomplete attribute does not necessary for accessibility"
     },
     "accesskeys": {
       "pass": "Accesskey attribute value is unique",

test/checks/forms/autocomplete-valid.js

@@ -21,6 +21,11 @@ describe('autocomplete-valid', function () {
     assert.isFalse(evaluate.apply(checkContext, params));
   });
 
+  it('returns undefined (incomplete) if autocomplete is ignored', function () {
+    var params = checkSetup('<input autocomplete="text" id="target" />');
+    assert.isUndefined(evaluate.apply(checkContext, params));
+  });
+
   it('uses options to change what is valid autocomplete', function () {
     var options = { stateTerms: ['foo'] };
     var params = checkSetup(

test/integration/rules/autocomplete-valid/autocomplete-valid.html

@@ -170,3 +170,10 @@
 <input autocomplete="section-foo email webauthn" id="pass92" />
 <input autocomplete="section-foo work email webauthn" id="pass93" />
 <input autocomplete="section-foo billing work email webauthn" id="pass94" />
+
+<!-- Incomplete, ignored values -->
+<input autocomplete="text" id="incomplete1" />
+<input autocomplete="pronouns" id="incomplete2" />
+<input autocomplete="gender" id="incomplete3" />
+<input autocomplete="message" id="incomplete4" />
+<input autocomplete="content" id="incomplete5" />

test/integration/rules/autocomplete-valid/autocomplete-valid.json

@@ -2,6 +2,13 @@
   "description": "autocomplete-valid tests",
   "rule": "autocomplete-valid",
   "violations": [["#fail1"], ["#fail2"], ["#fail3"], ["#fail4"], ["#fail5"]],
+  "incomplete": [
+    ["#incomplete1"],
+    ["#incomplete2"],
+    ["#incomplete3"],
+    ["#incomplete4"],
+    ["#incomplete5"]
+  ],
   "passes": [
     ["#pass1"],
     ["#pass2"],