Fix the dlitem rule for XHTML documents
#652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In XHTML, `element.tagName` preserves the case. In the `dlitem` check, the tag name is now upper-cased before being tested as 'DL', to make the rule work on XHTML documents. Fixes dequelabs#581
|
@WilcoFiers ready to be reviewed. This is a very simple fix, so maybe it can be added to 2.6? (sorry for the late submission). Note that this only affects the 2.x branch. The CI failures seem to be unrelated to this PR and was apparently introduced by commit 4dbb6a6 according to the CI build. |
WilcoFiers
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In XHTML,
element.tagNamepreserves the case.In the
dlitemcheck, the tag name is now upper-cased beforebeing tested as '
DL', to make the rules works on XHTML documents.Fixes #581