Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: td-has-heading to ignore td with its role changed #928

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented May 28, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

Description of the changes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

assert.isFalse(axe.commons.table.isDataCell(target3));
});

it('should return true for elements with role="(grid)cell"', function () {
Copy link
Contributor

@jeeyyy jeeyyy May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

role="(grid)cell" - what is the intention behind the brackets around (grid)? Tests for 2 scenarios?, worth separating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

role=gridcell and role=cell I don't see the point of separate cases. It's the same functionality. It's just data.

@WilcoFiers WilcoFiers merged commit d68af4c into develop Jun 4, 2018
@WilcoFiers WilcoFiers deleted the td-has-rowheader branch June 4, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: 'td-has-header' fails for cells having 'role=columnheader' or 'role=rowheader' as headers
2 participants