-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): aria-allowed-role #945
Merged
Merged
Changes from 15 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
63c947b
feat: initial work for new rule > aria-allowed-role
jeeyyy 7298f15
fix: aria-allowed-role rule
jeeyyy ee23a9d
chore: merge from > develop
jeeyyy 03af3af
fix: integration test fixes.
jeeyyy 9646b5b
chore: merge from > develop
jeeyyy 5a040ef
refactor: amends based on review.
jeeyyy 4642828
fix: merge from develop
jeeyyy 099c8d1
fix: update aria.isAllowedRole check to be self sufficient.
jeeyyy 75331d1
fix: merge from develop
jeeyyy 56df2df
fix: update checks based on review comments
jeeyyy 3cbd477
fix: editorial fixes based on review
jeeyyy 604b4ea
fix: refactored roleMap to have allowedElements
jeeyyy 2570ae1
test: update integration tests
jeeyyy 788dca2
test: deprecate old test unncessary due to refactor
jeeyyy 078c75c
fix: merge from develop
jeeyyy f725e21
fix: refactor based on code review
jeeyyy 256db5d
test: update unit/ integration tests
jeeyyy 5b44d65
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 79b00e0
refactor: change pass/ fail messages to respect plurals
jeeyyy b893dc7
refactor: update rule description
jeeyyy 4c3261d
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 9b686ea
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 5cd376a
fix: updates based on review
jeeyyy 8384f65
test: add more integration tests
jeeyyy 9e31d79
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 257a789
fix: swap node.matches with axe.utils.matchesSelector method
jeeyyy 5ecb795
chore: Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy a6d5bba
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 02c15cf
fix: updates based on review
jeeyyy 3502365
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy d69a797
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 87929c7
fix: improve test and refactor based on review
jeeyyy 7a0df2c
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy 2d86762
fix: enhance no role and any role as per aria spec
jeeyyy 8f16a86
test: add tests for aria-allowed-role related functions
jeeyyy d72a247
Merge branch 'develop' into new-rule-aria-allowed-role
jeeyyy ac0ba14
test: fix tests allowedElement object structure
jeeyyy 2777dbc
chore: merge from develop
jeeyyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/** | ||
* Implements allowed roles defined at: | ||
* https://www.w3.org/TR/html-aria/#docconformance | ||
* https://www.w3.org/TR/SVG2/struct.html#implicit-aria-semantics | ||
*/ | ||
const { allowImplicit = true, ignoredTags = [] } = options || {}; | ||
const tagName = node.tagName.toLowerCase(); | ||
|
||
// check if the element should be ignored, by an user setting | ||
if (ignoredTags && ignoredTags.includes(tagName)) { | ||
return true; | ||
} | ||
|
||
return axe.commons.aria.isAriaAllowedRole(node, tagName, allowImplicit); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"id": "aria-allowed-role", | ||
"evaluate": "aria-allowed-role.js", | ||
"options": { | ||
"allowImplicit": true, | ||
"ignoredTags": [] | ||
}, | ||
"metadata": { | ||
"impact": "minor", | ||
"messages": { | ||
"pass": "ARIA role(s) is allowed for given element", | ||
"fail": "Role(s) must be one of the allowed ARIA roles" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should expose which role(s) aren't allowed for which element. |
||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this is only a best practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestions what this could be @marcysutton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could double check with @goodwitch, but I don't think this is a WCAG issue.