fix: show all terminating pods in Faults view (#2738)

[gomesdigital]

Fixes #2738.

[derailed]

@gomesdigital Thank you for this pr! I am not sure I understand the intent. Fault view highlights pods that are in trouble but is a terminating pod an actual fault? This is part of the normal lifecycle of a pod.
Now pods that are stuck in terminating state could be indeed an issue but we would then have to monitor events to determine which pods should land in the fault view.
But if you are wanting to list pods in terminating state you could simply filter these while in pod view.

[gomesdigital]

Thanks for the quick response @derailed.

Fault view highlights pods that are in trouble but is a terminating pod an actual fault? This is part of the normal lifecycle of a pod.

By the current definition, no—but eventually, any pod in Terminating does show up in Faults once it's containers come down (like when rolling a deployment). So normal terminations will show there. I'm advocating to include "any pod in terminating" because this adds the irregular terminations to the fault view (if any), which is what brought our attention to the issue.

That includes either a) stuck in terminating (with containers still ready), b) affected by issues like Node Not Ready as reported in the issue discussion, or c) any other irregular Termination. Otherwise, they’ll transiently appear in the Faults view right before they shut down, which maintains the status quo and is currently considered normal.

I believe these cases should qualify as "faults" because while Terminating is part of a pod’s normal lifecycle, persistent Terminating states or irregular terminations often highlight underlying faults that would benefit from visibility in the Faults view. Users expect to see all pods in problematic states and excluding these cases can be a trip wire.

[gomesdigital]

Let me know if that change makes sense. 👍 To me its a clear route considering most pods will already show up in Fault view as Terminating. I'm open to other suggestion as well!

[derailed]

@gomesdigital Thank you for the details! I see your point.

[derailed]

@gomesdigital Thank for the update.