Use "GoReleaser" #395
Use "GoReleaser" #395
Conversation
|
@BenElgar I need to study the release machinery that @kendru put together to make sure I don't screw anything up switching over to this. Then I'll get the Homebrew package working. Once that's good, I'll ask you to investigate the Linux packaging story. No ETA yet, this is stacked up behind a few things on my queue, so let me know if you get spare cycles for the Linux stuff before I get to the Mac stuff. Thanks! |
brandonbloom
force-pushed
the
main
branch
20 times, most recently
from
d4e2433 to
f757337
Compare
|
@BenElgar will take over this work & can do with this specific PR as he likes :) |
|
@brandonbloom okay I think that now this should, combined with https://github.com/deref/exo-install/pull/4/files, do the right thing. That being said, I haven't done a great deal of testing since it's kind of a nuisance to do it locally. Assuming you're happy, my plan is to test in prod by pushing a version number that precedes our current release. The auto upgrade functionality that we've already released will stop working if we choose an initial version number less than 3.0. Alternatively I think we could stick with CalVer. |
.github/workflows/goreleaser.yaml
Outdated
|
|
||
| # Needed to create a Github release with archives. | ||
| #permissions: | ||
| # contents: write |
There was a problem hiding this comment.
Presumably you need to uncomment this?
There was a problem hiding this comment.
Yeah I was going to see if it worked without it before I set that flag.
.goreleaser.yml
Outdated
| - make codegen | ||
| #- make -C gui | ||
| env: | ||
| - CGO_ENABLED=0 |
There was a problem hiding this comment.
If CGO_ENABLED is not 1, the build will succeed, but as soon as you try to open a Sqlite database, you'll encounter an error saying that CGO must be enabled.
.goreleaser.yml
Outdated
| hooks: | ||
| - go mod tidy | ||
| - make codegen | ||
| #- make -C gui |
There was a problem hiding this comment.
Ah yes, need to uncomment that — I just disabled it for testing.
.goreleaser.yml
Outdated
| - CGO_ENABLED=0 | ||
| builds: | ||
| # This is the build for use in the install script. | ||
| - id: autoinstalled |
There was a problem hiding this comment.
nit picky: seems like an odd name for this. Does this name show up anywhere else? Like in the built files or whatever?
There was a problem hiding this comment.
What about "standalone"?
There was a problem hiding this comment.
Yes, I was using the names from the files in ./internal/upgrade. Happy to change it to standalone though.
There was a problem hiding this comment.
Yeah, I think "standalone" is much clearer to me. Please change. Thanks!
.goreleaser.yml
Outdated
| # This is the build for use by package managers. | ||
| - id: managed | ||
| main: . | ||
| goos: |
There was a problem hiding this comment.
In addition to goos, we also need to build for goarch set to both amd64 and arm64, at least on darwin
There was a problem hiding this comment.
The default is to build for arm64, amd64 and i386: https://goreleaser.com/customization/build/
There was a problem hiding this comment.
Do we need i386 support? Seems like that's extremely unlikely for any developer machine these days.
I'd suggest dropping that and making this configuration explicit.
|
Okay I tested this on a fork here: https://github.com/BenElgar/exo/releases It seems to do the right thing and the homebrew install works on Linux at least. I'm going to test on macOS now. |
|
Ah no, it turns out we have a limit of at most zero mac instances in our AWS account. I've requested a limit increase but that usually takes a day or so. |
|
Okay I've tested and fixed the release process on the aforementioned fork and I've checked that it all works on macOS. Going to merge this. |
No description provided.