Raise on unknown/invalid curl flags #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinschweikert can you add a changelog entry for this? I missed that in my initial check. |
|
This is a breaking change, so I have bumped the version to 0.90.0. |
|
I don't know exactly if it is breaking. As I showed in #24 it would produce a MatchError anyway, that's why I initially didn't provide a Changelog entry. But it's better to be transparent and on the safe side! Thanks for checking! Happy holidays 🎄 |
|
Ah, I see. Well, it has been released now anyways! Happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
We need to raise instead of just logging a warning because with an unknown flag we do not know if it is just a boolean flag or needs a value. But instead of just the stacktrace, we can explain why we fail at this stage and help guide the user.
Example:
curl -k https://example.comwould work if we would know that it's a boolean flag but when we parse it the URI gets set as the value for "-k" and the URI itself will be empty.